New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackableMaker.doWith method needs to be documented to warn about its thread-local behavior #1576

Merged
merged 3 commits into from Jun 12, 2014

Conversation

Projects
None yet
3 participants
@izmailoff
Copy link
Contributor

izmailoff commented Jun 11, 2014

@fmpwizard

This comment has been minimized.

Copy link
Member

fmpwizard commented Jun 11, 2014

👍

@Shadowfiend

This comment has been minimized.

Copy link
Member

Shadowfiend commented Jun 12, 2014

Hmm… This is not ideal (the comment should probably describe what the method does and simply mention as part of that description that it is thread-local), but it's enough to be getting on with. Let's do it.

Shadowfiend added a commit that referenced this pull request Jun 12, 2014

Merge pull request #1576 from izmailoff/master
StackableMaker.doWith method needs to be documented to warn about its thread-local behavior

@Shadowfiend Shadowfiend merged commit 2bb2f24 into lift:master Jun 12, 2014

@Shadowfiend Shadowfiend modified the milestones: 2.6-RC1, 2.6-M4 Aug 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment