New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with deprecations in mongo-java-driver v2.12 #1581

Merged
merged 3 commits into from Jun 15, 2014

Conversation

Projects
None yet
2 participants
@eltimn
Copy link
Member

eltimn commented Jun 14, 2014

Fixes #1579

eltimn added some commits Jun 14, 2014

Remove Mongo.defineDbAuth function that takes a MongoClient as an arg…
…ument and updated deprecation message for the other defineDbAuth functions.

When the new code for using MongoClient was added the functions that take a Mongo instance as argument were deprecated, including defineDbAuth. However, a subsequent update in the mongo-java-driver also deprecated DB.authenticate. Replaced by passing credentials in via MongoClient. So, I removed the new defineDbAuth function.
/**
* Define and authenticate a Mongo db using a MongoClient instance.
*/
def defineDbAuth(name: ConnectionIdentifier, mngo: MongoClient, dbName: String, username: String, password: String) {

This comment has been minimized.

@fmpwizard

fmpwizard Jun 14, 2014

Member

Just checking but, if a user is using this deleted method, will the one that takes a Mongo instance take over or will it be a compiler error?

This comment has been minimized.

@eltimn

eltimn Jun 14, 2014

Author Member

This method has only existed for a few weeks and was never part of a release. That's why I just deleted it instead of deprecating it.

To answer your question, I believe the other method would take over, but I did not test that.

This comment has been minimized.

@fmpwizard

fmpwizard Jun 14, 2014

Member

Sounds good

@fmpwizard

This comment has been minimized.

Copy link
Member

fmpwizard commented Jun 14, 2014

👍

@fmpwizard fmpwizard added this to the 2.6-M4 milestone Jun 15, 2014

fmpwizard added a commit that referenced this pull request Jun 15, 2014

Merge pull request #1581 from lift/tcn_issue_1579
Deal with deprecations in mongo-java-driver v2.12

@fmpwizard fmpwizard merged commit a7bdbcc into master Jun 15, 2014

@fmpwizard fmpwizard deleted the tcn_issue_1579 branch Jun 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment