New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally exclude the Position.scala file in Scala <2.11. #1590

Merged
merged 1 commit into from Jun 27, 2014

Conversation

Projects
None yet
4 participants
@Shadowfiend
Copy link
Member

Shadowfiend commented Jun 25, 2014

Position is something we imported from scala.io because it was removed in Scala
2.11; in 2.10, we can lean on the one in the scala library. For people who used
sbt assembly to build fat JARs, having both in two different JARs resulted in
nasty-sauce. We now exclude it when building for Scala versions below 2.11 so
this issue doesn't come up.

This fixes #1588.

@Shadowfiend Shadowfiend added this to the 2.6-RC1 milestone Jun 25, 2014

Conditionally exclude the Position.scala file in Scala <2.11.
Position is something we imported from scala.io because it was removed in Scala
2.11; in 2.10, we can lean on the one in the scala library. For people who used
sbt assembly to build fat JARs, having both in two different JARs resulted in
nasty-sauce. We now exclude it when building for Scala versions below 2.11 so
this issue doesn't come up.
@fmpwizard

This comment has been minimized.

Copy link
Member

fmpwizard commented Jun 25, 2014

👍

@Shadowfiend

This comment has been minimized.

Copy link
Member Author

Shadowfiend commented Jun 25, 2014

Haven't run all the tests under both 2.10 and 2.11 yet, doing that now.

@Shadowfiend

This comment has been minimized.

Copy link
Member Author

Shadowfiend commented Jun 25, 2014

K, tests passed for me. Would appreciate some input from someone who was having the issues with sbt assembly. Also someone else running the tests, probably :D

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Jun 25, 2014

I'll try to find time to run the tests today.

@channingwalton

This comment has been minimized.

Copy link

channingwalton commented Jun 26, 2014

I'm happy to test, whats the best way? Is it in a snapshot version yet or do i need to build/publish locally?

@fmpwizard

This comment has been minimized.

Copy link
Member

fmpwizard commented Jun 26, 2014

you'll have to do some manual work,

  1. git clone git@github.com:lift/framework.git
  2. cd framework
  3. git checkout asc-issue-1588
  4. ./liftsh //this may take a while
  5. Now you are inside sbt
  6. project lift-framework--pre211 //this gets you in the right project to build
  7. ++2.10.4 //to change to scala 2.10.4 to build , again, may take some time
  8. publishLocal
  9. then in your project, change the dependency from lift 2.6-M4 to 2.6-SNAPSHOT
  10. make sure not to have your assembly workaround in place
  11. do your normal build process (make sure you don't see sbt downloading the jars for lift 2.6-snapshot from the internet, it should not, but sometimes ivy gets confused.
  12. it should build the jar without issues

Thanks!

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Jun 26, 2014

Giving these tests a run this morning. We'll see what happens.

@channingwalton

This comment has been minimized.

Copy link

channingwalton commented Jun 26, 2014

The snapshot works for me, our project builds nicely - thanks for instructions :)

@fmpwizard

This comment has been minimized.

Copy link
Member

fmpwizard commented Jun 26, 2014

Awesome!

On Thursday, June 26, 2014, Channing Walton notifications@github.com
wrote:

The snapshot works for me, our project builds nicely - thanks for
instructions :)


Reply to this email directly or view it on GitHub
#1590 (comment).

Diego Medina
Lift/Scala consultant
diego@fmpwizard.com
http://fmpwizard.telegr.am

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Jun 27, 2014

Tests appear to be passing under 2.10 and 2.11.

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Jun 27, 2014

Let's ship it!

farmdawgnation added a commit that referenced this pull request Jun 27, 2014

Merge pull request #1590 from lift/asc-issue-1588
Conditionally exclude the Position.scala file in Scala <2.11.

@farmdawgnation farmdawgnation merged commit 55e6081 into lift_26 Jun 27, 2014

@farmdawgnation farmdawgnation deleted the asc-issue-1588 branch Jun 27, 2014

@channingwalton

This comment has been minimized.

Copy link

channingwalton commented Jun 27, 2014

Thanks everyone.

Sent from my iPhone

On 27 Jun 2014, at 15:15, Matt Farmer notifications@github.com wrote:

Let's ship it!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment