Improve LAPinger documentation for clarity #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltimn
approved these changes
Aug 31, 2017
Shadowfiend
reviewed
Aug 31, 2017
| @@ -34,8 +34,8 @@ object ThreadPoolRules { | |||
| } | |||
|
|
|||
| /** | |||
| * The ActorPing object schedules an actor to be ping-ed with a given message at specific intervals. | |||
| * The schedule methods return a ScheduledFuture object which can be cancelled if necessary | |||
| * The LAPinger object schedules a LiftActor to be pinged "delay" miliseconds in the future. | |||
There was a problem hiding this comment.
The original phrasing seems clearer to me here (class names aside). delay doesn't really have a meaning at the level of the singleton that I can see.
|
@Shadowfiend Check the latest commit here and let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1778.