snippet Msgs.ShowAll should not be a session var #805

Merged
merged 1 commit into from Jul 1, 2012

3 participants

@dpp
Lift Web Framework member

More of the global nastiness around Msgs. I think I need to totally re-write the messages mechanism... perhaps to use wiring.

@dpp
Lift Web Framework member

There are also issues with S.error/S.notice/S.warning in the context of a CometActor

@dpp
Lift Web Framework member
@dpp dpp was assigned Mar 1, 2012
@fmpwizard fmpwizard was assigned Jun 20, 2012
@fmpwizard fmpwizard * Fixes 805 - snippet Msgs.ShowAll should not be a session var
By being a SessionVar, it meant that if you had two pages, one with showAll=true and the second
page with showAll=false (or omitted), messages that correspond to an ID would show or not
depending on which page was loaded last (setting the SessionVar to true or false).

Now we use a RequestVar and all is well.
0a98248
@dpp dpp merged commit cde876c into master Jul 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment