Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 64-bit binaries #35

Merged
merged 51 commits into from Jul 8, 2015
Merged

Conversation

@kumarak
Copy link
Contributor

@kumarak kumarak commented May 27, 2015

I have added change logs for 64-bit support in Changelist-64bit.txt. It will be nice to get feedback on current changes.

Thanks
--Akshay

@artemdinaburg
Copy link
Contributor

@artemdinaburg artemdinaburg commented Jun 22, 2015

This is amazing. Was just trying it out on Linux and almost everything works. Super exciting to see mcsema handling 64-bit instructions.

I tested on Linux, and here's some small issues I've found so far:

  • The demo14 and demo15 tests are no longer valid, since there is no more __fastcall or __stdcall on x86-64. Since these no longer serve a purpose, its best to just get rid of them.
  • Using IDA:
    • demo_maze and linked_elf_test both segfault, probably due to the same core issue.
    • demo7 gives incorrect results
  • Using bin_descend:
    • demo7 gives incorrect results
    • demo10 does not include lines with 0xBB
    • demo11 does not include lines with 0xBB

I'm going to set up a Windows build environment and test there to see what works and what doesn't. We can merge in once all the tests pass on Linux and add a guard against running 64-bit on Windows binaries, but I think its really important to keep Windows support in the long term.

@kumarak
Copy link
Contributor Author

@kumarak kumarak commented Jun 29, 2015

Hi Artem, Thanks for reporting the issue. I resolved Linux related issues and now test cases works with both bin_descend and IDA. The windows support is in progress and I will let you know once all the test cases will pass successfully.

artemdinaburg added a commit that referenced this pull request Jul 8, 2015
Support for 64-bit binaries
@artemdinaburg artemdinaburg merged commit a21f034 into lifting-bits:master Jul 8, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.