Permalink
Browse files

gateone.js: Fixed the bug where sometimes opening new terminals could…

… result with them being cut off at the top slightly (and the cursor not being able to move all the way to the bottom of the view).

terminal.py:  Modified the regex in JPEGFile.re_capture to be both more reliable and efficient.
INSTALL.txt:  Fixed the position of --prefix.
  • Loading branch information...
1 parent eb5dd82 commit 73cdc85049f88e428f1863182ef8000b02eac11f @liftoff committed Oct 20, 2012
Showing with 7 additions and 4 deletions.
  1. +1 −1 INSTALL.txt
  2. +5 −2 gateone/static/gateone.js
  3. +1 −1 gateone/terminal.py
View
@@ -5,7 +5,7 @@ To install Gate One from source execute the following from this directory:
By default it will be installed in /opt (/opt/gateone). If you want to install
it somewhere else just pass --prefix:
- python setup.py --prefix=/usr/local install
+ python setup.py install --prefix=/usr/local
To build an RPM package:
@@ -4492,12 +4492,15 @@ go.Base.update(GateOne.Terminal, {
if (!go.prefs.embedded) {
// In embedded mode this kind of adjustment can be unreliable
GateOne.Visual.applyTransform(termPre, ''); // Need to reset before we do the calculation
- var distance = goDiv.clientHeight - screenSpan.offsetHeight;
GateOne.terminals[term]['heightAdjust'] = 0; // Have to set this as a default value for new terminals
// Feel free to put something like this in updateTermCallbacks if you want.
if (GateOne.Utils.isVisible(termPre)) {
- var transform = "translateY(-" + distance + "px)";
+ // The timeout is here to ensure everything has settled down (completed animations and whatnot) before we do the distance calculation.
+ setTimeout(function() {
+ var distance = goDiv.clientHeight - screenSpan.offsetHeight,
+ transform = "translateY(-" + distance + "px)";
GateOne.Visual.applyTransform(termPre, transform); // Move it to the top so the scrollback isn't visible unless you actually scroll
+ }, 1000);
}
}
}
View
@@ -829,7 +829,7 @@ class JPEGFile(ImageFile):
re_header = re.compile(
'.*\xff\xd8\xff.+JFIF\x00|.*\xff\xd8\xff.+Exif\x00', re.DOTALL)
re_capture = re.compile(
- '\xff\xd8\xff.+JFIF\x00.*?\xff\xd9|\xff\xd8\xff.+Exif\x00.*?\xff\xd9',
+ '\xff\xd8\xff.+\xff\xd9',
re.DOTALL
)
html_template = '<img src="{src}" width="{width}" height="{height}">'

0 comments on commit 73cdc85

Please sign in to comment.