Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Midnight Commander doesn't work #1

Closed
lekv opened this Issue Oct 13, 2011 · 20 comments

Comments

Projects
None yet
4 participants

lekv commented Oct 13, 2011

I assume, that other curses-based applications have this issue as well:

Traceback (most recent call last):
File "/home/me/GateOne/gateone/termio.py", line 435, in proc_read
self.term_write(updated)
File "/home/me/GateOne/gateone/termio.py", line 350, in term_write
self.term.write(chars)
File "/home/met/GateOne/gateone/terminal.py", line 750, in write
csi_handlerscsi_type
TypeError: save_cursor_position() takes exactly 1 argument (2 given)

Owner

liftoff commented Oct 13, 2011

I haven't seen this one yet but that error tells me exactly what the problem
is (bug in the calling function). When I get home later it should only take
me a moment to fix.

Thanks for letting me know!
On Oct 13, 2011 5:49 PM, "gitpimp" <
reply@reply.github.com>
wrote:

I assume, that other curses-based applications have this issue as well:

Traceback (most recent call last):
File "/home/me/GateOne/gateone/termio.py", line 435, in proc_read
self.term_write(updated)
File "/home/me/GateOne/gateone/termio.py", line 350, in term_write
self.term.write(chars)
File "/home/met/GateOne/gateone/terminal.py", line 750, in write
csi_handlerscsi_type
TypeError: save_cursor_position() takes exactly 1 argument (2 given)

Reply to this email directly or view it on GitHub:
#1

Owner

liftoff commented Oct 14, 2011

I just made a change to terminal.py that should correct this issue. Please let me know if it's fixed. Thanks!

lekv commented Oct 14, 2011

Now MC comes up, but the blue background color is missing on some of the files. Typing "exit" in MC brings up the following in gatone's console:

Traceback (most recent call last):
File "/home/pimp/checkout/git/GateOne/gateone/termio.py", line 435, in proc_read
self.term_write(updated)
File "/home/pimp/checkout/git/GateOne/gateone/termio.py", line 350, in term_write
self.term.write(chars)
File "/home/pimp/checkout/git/GateOne/gateone/terminal.py", line 752, in write
csi_handlerscsi_type
File "/home/pimp/checkout/git/GateOne/gateone/terminal.py", line 577, in _set_top_bottom
top, bottom = settings.split(';')
ValueError: need more than 1 value to unpack

Owner

liftoff commented Oct 14, 2011

Argh, I hate debugging terminal emulation. I'm going to load up mc myself and see if I can't reproduce this. Any switches or settings I should give it to better replicate your environment?

Owner

liftoff commented Oct 14, 2011

I just pushed some new commits that fixed Midnight Commander. The colors still get a bit messed up but at least it works (and doesn't cause a crash). Let me know if the updates work for you.

ser commented Oct 18, 2011

another full-featured console app, htop, works, but when you want to quit it, it quits but does not return to a shell

Owner

liftoff commented Oct 18, 2011

@ser: Now wait just a minute... I had htop running in a Gate One window when you wrote this comment (LOL). I can close and re-open it without issue. Do you have an error in your logs that might indicate what your problem could be?

@ghost

ghost commented Oct 19, 2011

No, there is no visible error, I have turned on "info" level, but even with --debug no error is displayed. Htop quits and shell hangs - I need to restart and log again.

ser commented Oct 19, 2011

I have tested FF7 and ChromeOS, hangs on both. 100% clean accounts, first time logged in on this account, no cookies etc.

@ghost

ghost commented Oct 19, 2011

Funny thing, I accidentally have left a hanged htop for few hours, and after that time shell was back :)

Owner

liftoff commented Oct 20, 2011

Please pull my latest code changes and let me know if you're still having any of these issues. I changed so much (for the better) it just might have fixed it all for you. Let me know, thanks!

Owner

liftoff commented Oct 20, 2011

I just pushed some code changes that should fix all of your midnight commander and vim issues. In my tests everything is working pretty dang good. Please confirm =)

@ghost

ghost commented Oct 21, 2011

sorry mate, fresh install from git - after leaving htop - it hangs and does not react to ctlr-c or anything.

@ghost

ghost commented Oct 21, 2011

btw, it is Python 2.6.6 - maybe it is meaningful?

Owner

liftoff commented Oct 21, 2011

Well, that has nothing to do with midnight commander. Can you open a new ticket on the htop issue?

BTW: It's Python 2.6.6 but what OS?

@ghost

ghost commented Oct 21, 2011

Sure, I will.

mc generally works, but it does not refresh everything properly, but F10 works well :)

$ uname -r
2.6.36-vs2.3.0.36.38-beng
$ cat /etc/debian_version
6.0.2

Owner

liftoff commented Oct 21, 2011

I had no idea what you were talking about "generally works" until I started playing around with it... I think I can fix the refresh issue when scrolling files. I'll keep this open until I do :)

Owner

liftoff commented Oct 21, 2011

I just pushed a change that seems to have fixed most of the issues with Midnight Commander. You still get blocks instead of line drawing characters when the rendition is bold but this is a problem with the font (which I'll be changing as a result--going to check out the latest monospace stuff on Google's font directory =).

Anyway, can you test it out and let me know how it goes?

@ghost

ghost commented Oct 21, 2011

i can fully agree this time - mc works perfectly now! thanks a lot!

Owner

liftoff commented Oct 21, 2011

Great, I'm going to close this issue. Issue #1 has been closed, yay!

@liftoff liftoff closed this Oct 21, 2011

@pauldorn pauldorn pushed a commit to pauldorn/GateOne that referenced this issue Sep 22, 2015

@liftoff liftoff Added some logic to on_close() in gateone.py to avoid a transient exc…
…eption when WebSockets are closed. Also, I believe I fixed the bug reported in liftoff#1 where Midnight Commander would cause an exception in terminal.py when it tried to save the cursor position.
53b4116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment