New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module file names don't allow hyphens #130

Closed
eurochriskelly opened this Issue Oct 22, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@eurochriskelly

eurochriskelly commented Oct 22, 2015

I would like to be able to name modules in standard xquery "train-case" format.

e.g. my-xquery-module.xqy

This is pretty normal in XQuery but is not supported by the plugin which tries to sanitize the filename into camel case for some reason.

It should either allow hyphenated names or explain in the error message why it is refusing to create the file. I had to look in the source code to find out what caused the warning message.

(Really great plugin by the way!)

@ligasgr

This comment has been minimized.

Show comment
Hide comment
@ligasgr

ligasgr Oct 27, 2015

Owner

Hi,
Thanks for raising the issue.
The reason for not using hyphenated names was that IDEA in many places (internal IDEA engine code) does rely on names not containing any characters that are not alphanumeric.
I'll review if this is still the case and if not then the rules might get relaxed!

Thanks for using the plugin and letting me know how to improve it!

Owner

ligasgr commented Oct 27, 2015

Hi,
Thanks for raising the issue.
The reason for not using hyphenated names was that IDEA in many places (internal IDEA engine code) does rely on names not containing any characters that are not alphanumeric.
I'll review if this is still the case and if not then the rules might get relaxed!

Thanks for using the plugin and letting me know how to improve it!

@ligasgr ligasgr added the enhancement label Nov 15, 2015

@ligasgr

This comment has been minimized.

Show comment
Hide comment
@ligasgr

ligasgr Nov 18, 2015

Owner

Hi
The new rules for function names are as below:

  • has to start with either _ (underscore) or letter
  • can contain letters, numbers, hyphens, underscores
    Hope these rules make sense now
Owner

ligasgr commented Nov 18, 2015

Hi
The new rules for function names are as below:

  • has to start with either _ (underscore) or letter
  • can contain letters, numbers, hyphens, underscores
    Hope these rules make sense now

@ligasgr ligasgr closed this in cc34c13 Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment