New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations with literals don't work #73

Closed
dirkk opened this Issue Nov 8, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@dirkk

dirkk commented Nov 8, 2013

First of all: Thanks for this wonderful plugin. Looks very promising and I would very, very much love to finally have a useful XQuery tool.

The following code shows the error (at function) '%', function or variable expected, got 'function'

declare
  %rest:path("/test")
  function local:login() {
      <test />
  };

Without the string literal within the annotation (i.e. stripping "/test") everything works like a charm.

I would also love to fix this myself, but I'll first to have a look at idea plugin development, so this might take a while...

@ligasgr

This comment has been minimized.

Show comment
Hide comment
@ligasgr

ligasgr Nov 8, 2013

Owner

Hi, thanks for these very kind words and your feedback!
Indeed this doesn't work.
It's going to take some time before the release is ready so in the meanwhile you should be able to download and install (install plugin from disk) current version from master.
It's available under this link:
https://ligasgr.ci.cloudbees.com/job/intellij-xquery-master-prepare-distribution/ws/build/distributions/intellij-xquery.zip

Owner

ligasgr commented Nov 8, 2013

Hi, thanks for these very kind words and your feedback!
Indeed this doesn't work.
It's going to take some time before the release is ready so in the meanwhile you should be able to download and install (install plugin from disk) current version from master.
It's available under this link:
https://ligasgr.ci.cloudbees.com/job/intellij-xquery-master-prepare-distribution/ws/build/distributions/intellij-xquery.zip

@ghost ghost assigned ligasgr Nov 8, 2013

@ligasgr ligasgr closed this in 7593c4e Nov 8, 2013

@dirkk

This comment has been minimized.

Show comment
Hide comment
@dirkk

dirkk Nov 11, 2013

Wow, that was a really quick fix. The reported bug was properly fixed (thanks!).
However, I would vote for a reopening as annotation with multiple string literals (e.g. declare %rest:path("/test", "test2") function local:login() {<test/>};) still don't work.

dirkk commented Nov 11, 2013

Wow, that was a really quick fix. The reported bug was properly fixed (thanks!).
However, I would vote for a reopening as annotation with multiple string literals (e.g. declare %rest:path("/test", "test2") function local:login() {<test/>};) still don't work.

@ligasgr ligasgr reopened this Nov 11, 2013

@ligasgr

This comment has been minimized.

Show comment
Hide comment
@ligasgr

ligasgr Nov 11, 2013

Owner

Ahh. Right. I forgot to check grammar while fixing it :) Thanks for pointing that out.

Owner

ligasgr commented Nov 11, 2013

Ahh. Right. I forgot to check grammar while fixing it :) Thanks for pointing that out.

@ligasgr ligasgr closed this in 3203159 Nov 11, 2013

@ligasgr

This comment has been minimized.

Show comment
Hide comment
@ligasgr
Owner

ligasgr commented Nov 11, 2013

@dirkk

This comment has been minimized.

Show comment
Hide comment
@dirkk

dirkk Nov 11, 2013

Thanks, works like a charm!

dirkk commented Nov 11, 2013

Thanks, works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment