-
Notifications
You must be signed in to change notification settings - Fork 6
Replace black with ruff formatter in pre-commit #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #576 will degrade performances by 36.52%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_benchmark_naive |
2.3 ms | 2 ms | +14.3% |
| ❌ | WallTime | test_benchmark_rust |
61.4 µs | 68.8 µs | -10.77% |
| ⚡ | WallTime | test_benchmark_lc_py |
3.9 ms | 3.3 ms | +16.63% |
| ⚡ | WallTime | test_benchmark_cesium |
3.6 ms | 3.3 ms | +11.04% |
| ❌ | WallTime | test_benchmark_rust |
2 µs | 3.1 µs | -36.52% |
| ⚡ | WallTime | test_benchmark_lc_py |
446.6 µs | 359.5 µs | +24.22% |
| ⚡ | WallTime | test_benchmark_naive |
430 µs | 345.2 µs | +24.58% |
| ⚡ | WallTime | test_benchmark_naive |
2.1 ms | 1.6 ms | +29.9% |
| ⚡ | WallTime | test_benchmark_naive |
2.1 ms | 1.6 ms | +28.86% |
| ⚡ | WallTime | test_benchmark_lc_py |
3.9 ms | 3.4 ms | +16.25% |
| ⚡ | WallTime | test_benchmark_cesium |
3.8 ms | 3.4 ms | +10.86% |
| ⚡ | WallTime | test_benchmark_lc_py |
34.8 µs | 29.7 µs | +17.32% |
| ❌ | WallTime | test_benchmark_rust |
2.3 µs | 2.6 µs | -12% |
| ⚡ | WallTime | test_benchmark_lc_py |
47.6 µs | 40 µs | +19.12% |
| ❌ | WallTime | test_benchmark_rust |
3.6 µs | 4.8 µs | -24.05% |
| ⚡ | WallTime | test_benchmark_lc_py |
29.9 µs | 24.9 µs | +20.27% |
| ⚡ | WallTime | test_benchmark_naive |
19.8 µs | 17.8 µs | +11.21% |
| ❌ | WallTime | test_benchmark_rust |
3.1 µs | 3.4 µs | -10.28% |
| ⚡ | WallTime | test_benchmark_lc_py |
34.2 µs | 28.3 µs | +20.64% |
| ⚡ | WallTime | test_benchmark_naive |
23.7 µs | 21.3 µs | +11.06% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Footnotes
-
No successful run was found on
master(86853a3) during the generation of this report, so 3ef2535 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩ -
106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 9 9
Lines 2604 2604
=======================================
Hits 2151 2151
Misses 453 453 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: hombit <1784493+hombit@users.noreply.github.com>
Co-authored-by: hombit <1784493+hombit@users.noreply.github.com>
d19b1b0 to
c870392
Compare
Replaces the Black formatter with Ruff's built-in formatter (
ruff-format) in the pre-commit configuration. Ruff format is a drop-in Black replacement with better performance.Changes
.pre-commit-config.yaml: Removedblack-pre-commit-mirrorrepo, addedruff-formathook to existingruff-pre-commitrepolight-curve/pyproject.toml: Removedblackfrom dev dependenciesRuff format uses its default configuration which is fully compatible with Black's behavior.
<issue_title>pre-commit: replace black with ruff formatter </issue_title>
><issue_description></issue_description>
>
> ## Comments on the Issue (you are @copilot in this section)
>
>
>
>
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.