Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

The macOS x86_64 CI packaging was failing because the compiler couldn't find Homebrew-installed FFTW and other system libraries. The workflow only set CPATH and LIBRARY_PATH for ARM runners (macos-14), not Intel runners (macos-13).

Changes:

  • Extended Homebrew path setup from ARM-only (matrix.os == 'macos-14') to all macOS runners (runner.os == 'macOS')
  • brew --prefix automatically resolves to /opt/homebrew on ARM and /usr/local on x86_64
# Before: only ARM macOS
- name: Set up Homebrew paths on ARM macOS
  if: ${{ matrix.os == 'macos-14' }}

# After: all macOS
- name: Set up Homebrew paths on macOS
  if: ${{ runner.os == 'macOS' }}
Original prompt

This section details on the original issue you should resolve

<issue_title>CI: macOS x86_64 packaging is broken</issue_title>
<issue_description>https://github.com/light-curve/light-curve-python/actions/runs/19038835966/job/54370213018</issue_description>

<agent_instructions>For some reason macOS x86_64 packaging CI in github actions stopped working, complaining about FFTW linking. Can you debug it on macos x86_64?</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: hombit <1784493+hombit@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix macOS x86_64 packaging issue in CI Fix macOS x86_64 packaging: add Homebrew paths for Intel runners Nov 14, 2025
Copilot AI requested a review from hombit November 14, 2025 21:31
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #578 will not alter performance

Comparing copilot/debug-macos-x86-64-packaging (b700dc7) with master (d178dbe)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 106 untouched
⏩ 106 skipped1

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@hombit hombit marked this pull request as ready for review November 14, 2025 21:59
@hombit hombit enabled auto-merge November 14, 2025 21:59
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.60%. Comparing base (d178dbe) to head (b700dc7).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files           9        9           
  Lines        2604     2604           
=======================================
  Hits         2151     2151           
  Misses        453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hombit hombit merged commit 2863c40 into master Nov 14, 2025
82 checks passed
@hombit hombit deleted the copilot/debug-macos-x86-64-packaging branch November 14, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: macOS x86_64 packaging is broken

2 participants