MiMa build version is now injected using ``sbt-buildinfo`` plugin #14

Merged
merged 1 commit into from Jun 6, 2012

Conversation

Projects
None yet
2 participants
Collaborator

dotta commented Jun 6, 2012

Added sbt-buildinfo plugin to MiMa core project definition, so that
the buildVersion defined inside Build.scala is now injected during
sbt source-generation phase.

Fixed #9

As part of this pull request, I should also update the README and provide some information on how to correctly set up sbteclipse, because the src-managed folder has to be listed in the project's build-path. According to sbteclipse doc I need something like the following:

EclipseKeys.createSrc := EclipseCreateSrc.Default + EclipseCreateSrc.Managed

But given my unfamiliarity with sbt, I'm not sure where this should go. Would you guys have any idea?

MiMa build version is now injected using ``sbt-buildinfo`` plugin
Added ``sbt-buildinfo`` plugin to MiMa core project definition, so that
the ``buildVersion`` defined inside ``Build.scala`` is now injected during
sbt source-generation phase.

Fixed #9
Contributor

jsuereth commented Jun 6, 2012

Looks great!

jsuereth added a commit that referenced this pull request Jun 6, 2012

Merge pull request #14 from dotta/topic/#9-inject-build-version
MiMa build version is now injected using ``sbt-buildinfo`` plugin

@jsuereth jsuereth merged commit 8f76fbc into lightbend:master Jun 6, 2012

Collaborator

dotta commented Jun 6, 2012

Great. Though, any experience with sbteclipse and src-managed folder? \cc @hseeberger

As part of this pull request, I should also update the README and provide some information on how to correctly set up sbteclipse, because the src-managed folder has to be listed in the project's build-path. According to sbteclipse doc I need something like the following:

EclipseKeys.createSrc := EclipseCreateSrc.Default + EclipseCreateSrc.Managed

But given my unfamiliarity with sbt, I'm not sure where this should go. Would you guys have any idea?

Contributor

jsuereth commented Jun 6, 2012

ugh.... yeah I know where it goes but we lamed up our sbt plugin ability
here...

You can put it in /.sbt/foo.sbt and it appies to all your projects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment