Topic/fix test classpath #7

Merged
merged 4 commits into from May 25, 2012

Conversation

Projects
None yet
2 participants
@dotta
Collaborator

dotta commented May 25, 2012

  • This fix the issue with the failing test (this was a side effect of re-writing git's history)
  • I've also made a few minor changes here and there.

dotta added some commits May 25, 2012

Missed SBT run config in package refactoring
The run config in build.sbt was not updated after the packaging refactoring
done in SHA #53725d0607aa339af020a75c465208416f3a9a00.
Fixed failing test
The issue was that the test runner (i.e., ``CollectProblemsTest``), had an
hardcoded reference to the Scala library, which is needed to correctly run the
test. However, due to recent git-history re-writing (which has considerably
reduced the repo's size), the Scala library JAR referenced in the test was no
longer available.

The fix is to pass the ``testClasspath`` to the test runner, and at the moment
the ``testClasspath`` only contains a reference to the Scala library's path
used to build the project itself.
oraclePath: String): Unit
}]
+ // Add the scala-library to the MiMa classpath used to run this test
+ val testClasspath = data(cp).filter(_.getName endsWith "scala-library.jar").map(_.getAbsolutePath).toList

This comment has been minimized.

Show comment Hide comment
@dotta

dotta May 25, 2012

Collaborator

Josh, is there a better way to express this?

@dotta

dotta May 25, 2012

Collaborator

Josh, is there a better way to express this?

This comment has been minimized.

Show comment Hide comment
@jsuereth

jsuereth May 25, 2012

Contributor

Maybe if you use scalaInstance. Not worth it perhaps....

@jsuereth

jsuereth May 25, 2012

Contributor

Maybe if you use scalaInstance. Not worth it perhaps....

jsuereth added a commit that referenced this pull request May 25, 2012

@jsuereth jsuereth merged commit 40bbcf5 into lightbend:master May 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment