New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to update metadata with same API that creates metadata #55

Closed
jewzaam opened this Issue Jul 9, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@jewzaam
Copy link
Member

jewzaam commented Jul 9, 2014

From a maintenance point of view it is easier to have a single json document that represents metadata for both create and update. Just keep the current state in it. The create schema API today expects just the schema JSON. This means for create vs update via cli I have to break out schema into a separate file or paste to the curl command from the full metadata. Ugly to manage. I don't want or need history of versions as this is in a git repo AND is tracked in lightblue.

@bserdar

This comment has been minimized.

Copy link
Contributor

bserdar commented Nov 6, 2014

We can have the createSchema accept two possible inputs, and operate based on what's provided"

  1. only schema is submitted: create the schema
  2. EntityMetadata is submitted: create the schema, update the entityInfo

Is this a good idea?

@jewzaam

This comment has been minimized.

Copy link
Member Author

jewzaam commented Nov 10, 2014

How about createMetadata supports create or update? Leave schema creation as-is. I think this is cleaner from a REST API point of view. The create metatadata api takes the version as a path param already.

http://docs.lightblue.io/rest_specification/metadata.html#put-create-new-metadata

----- Original Message -----

We can have the createSchema accept two possible inputs, and operate based on
what's provided"

  1. only schema is submitted: create the schema
  2. EntityMetadata is submitted: create the schema, update the entityInfo

Is this a good idea?


Reply to this email directly or view it on GitHub:
#55 (comment)

@derek63 derek63 modified the milestones: 1.2.0, 1.1.0 Nov 11, 2014

@bserdar bserdar added in progress and removed ready labels Dec 22, 2014

@bserdar bserdar self-assigned this Dec 22, 2014

@bserdar

This comment has been minimized.

Copy link
Contributor

bserdar commented Dec 22, 2014

This is being fixed in lightblue-rest. All the required APIs are already provided by core, so it is much easier to implement it there.

@bserdar

This comment has been minimized.

Copy link
Contributor

bserdar commented Dec 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment