New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize & handle brotli compression of the response body #742

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@n0m0r3pa1n

n0m0r3pa1n commented Apr 18, 2018

I needed Brotli compression recognition because I wanted to get some data from Facebook which use this algorithm.

@hidenny

This comment has been minimized.

hidenny commented Aug 13, 2018

Hello @n0m0r3pa1n do you have a complied Jar file with brotli supported? I have tried to edit and compile, however it shows an error "Caused by: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown" in my project.

Many thanks!!!

@Fohlen

This comment has been minimized.

Fohlen commented Sep 16, 2018

Hello @jekh
I tested these changes and verified that it works on resources where brotli compression is enabled.
What needs to be done in order to merge this to master and make a release?

Also @hidenny you can ask me for a compiled version, if you like.

@Fohlen

This PR seems fine.
However I wonder why doesn't the meteorgroup compile this changes somewhere? Using a private brotli upload seems a bit weird.

</dependencies>
<repositories>
<repository>
<id>bintray-nitram509-jbrotli</id>

This comment has been minimized.

@Fohlen

Fohlen Sep 16, 2018

Better not rely on a private bintray repo, why is there no official build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment