From 92895c828fd8df826f33803bdee220b58fbbce74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adam=20Mo=C4=8Dko=C5=99?= Date: Tue, 28 Mar 2023 09:57:07 +0200 Subject: [PATCH 1/2] fix modal not showing --- packages/example-t3/src/components/Modal/styles/mixins.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/example-t3/src/components/Modal/styles/mixins.scss b/packages/example-t3/src/components/Modal/styles/mixins.scss index 99f16ea..9bba794 100644 --- a/packages/example-t3/src/components/Modal/styles/mixins.scss +++ b/packages/example-t3/src/components/Modal/styles/mixins.scss @@ -43,6 +43,9 @@ overflow: auto; -webkit-overflow-scrolling: touch; + // TODO: we have clash of styles comming from @components .modal and .modal in this component - we should idially migrate this modal component to @components to fix this. Until than here are some overrides to make modal work as expected + visibility: visible; + //TODO: could this be replaced with utils.variants? @each $breakpoint, $props in $settings { @include tokens.breakpoint($breakpoint) { From 09bdf8d907fdd1fa7c45fa0e73a9763f9b9c103e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adam=20Mo=C4=8Dko=C5=99?= Date: Tue, 28 Mar 2023 10:01:07 +0200 Subject: [PATCH 2/2] add changeset --- .changeset/fast-books-mate.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fast-books-mate.md diff --git a/.changeset/fast-books-mate.md b/.changeset/fast-books-mate.md new file mode 100644 index 0000000..07e5716 --- /dev/null +++ b/.changeset/fast-books-mate.md @@ -0,0 +1,5 @@ +--- +"example-t3": patch +--- + +Fix modal not showing