Skip to content

Conversation

@pecoram
Copy link
Contributor

@pecoram pecoram commented Jan 24, 2025

No description provided.

@pecoram pecoram requested a review from wouterlucas January 27, 2025 10:49
Copy link
Contributor

@wouterlucas wouterlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@wouterlucas wouterlucas added this pull request to the merge queue Jan 27, 2025
Merged via the queue into lightning-js:main with commit b709fc8 Jan 27, 2025
2 checks passed
@elsassph
Copy link
Contributor

@wouterlucas @pecoram did you verify that sub-textures have the same loaded state as the parent texture?

@wouterlucas
Copy link
Contributor

they do, and works on WebGL but since we moved to more refined texture types the Canvas Renderer was missing support for a SubTexture specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants