fix: Unify texture state & subtexture fixes #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterlucas
requested review from
erikhaandrikman,
jfboeve and
michielvandergeest
wouterlucas
force-pushed
the
fix/texture-states
branch
from
67daf03 to
c8506df
Compare
jfboeve
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Texture Throttling added a duality for texture states a) management of downloading the source and b) the creation of the texture on the GPU. This introduced extra complexity that lead to edge cases, instead simplify it all in 1 state and extend the Texture state with
fetchingandfetchedto denote the state of the source generation/download.Additional changes added to fix race conditions with
subTextures, this change will have the texture source of the subtexture wait until the parent source texture is loaded (as per @pecoram reported issue on Discord).And added the deletion of the source data of the image per #499 right after creation of the GPU texture.