fix: update texture cleanup logic #619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning change in behaviour
Previously texture that couldn't be uploaded due to
doNotExceedCriticalThreshold: truewould be re-added in the queue, resulting in "stuck" textures.This change will put textures to
failedif they can't be uploaded due todoNotExceedCriticalThreshold: true. This will allow the engine/application to handle the failure and re-attempt to upload the texture (or apply fallback logic in the app).The setting
doNotExceedCriticalThresholdshould only be used when the memory is extremely tight, otherwise setting it tofalseand a lower threshold to have a little headroom will mimick the same behaviour as Lightning 2.Other changes:
failedifdoNotExceedCriticalThreshold: true