Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Tor support #117
This is my first ever pull request so please let me know what I'm doing wrong.
This change adds a button to the node launcher GUI that:
This change only works on Windows so far.
I'm not a Tor expert and so security review is still needed.
PierreRochard left a comment
I love where this is going! It'll be safer to write to the configuration files using the ConfigurationFile class https://github.com/PierreRochard/node-launcher/blob/master/node_launcher/services/configuration_file.py
Just as a point of interest more than anything else at this stage, you might like to check out Core's plan to split the configuration files in two; a read-write one which the GUI can effectively modify (bitcoin-conf-rw) and one which the daemon/GUI won't be able to modify (bitcoin.conf):
It would only require minimal changes for this project though I think as we are intentionally modifying those files (settings) on the user's behalf.