Skip to content

Clarify the sighash types for HTLC Success and Timeout transactions - #954

Merged
t-bast merged 1 commit into
lightning:masterfrom
lightning-signer:clarify-htlc-anchor-sighash
Jan 31, 2022
Merged

Clarify the sighash types for HTLC Success and Timeout transactions#954
t-bast merged 1 commit into
lightning:masterfrom
lightning-signer:clarify-htlc-anchor-sighash

Conversation

@ksedgwic

Copy link
Copy Markdown
Contributor

No description provided.

@t-bast

t-bast commented Jan 17, 2022

Copy link
Copy Markdown
Collaborator

This is already stated here: https://github.com/lightning/bolts/blob/master/05-onchain.md#generation-of-htlc-transactions
Maybe you can instead just add a link to it?

@ksedgwic
ksedgwic force-pushed the clarify-htlc-anchor-sighash branch from 0b0aa55 to 655915c Compare January 19, 2022 19:19
@ksedgwic

Copy link
Copy Markdown
Contributor Author

This is already stated here: https://github.com/lightning/bolts/blob/master/05-onchain.md#generation-of-htlc-transactions Maybe you can instead just add a link to it?

Sounds good, how does this look?

@t-bast t-bast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ACK 655915c

@vincenzopalazzo vincenzopalazzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 655915c

@rustyrussell

Copy link
Copy Markdown
Collaborator

Ack 655915c

@t-bast
t-bast merged commit d975de1 into lightning:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants