From 67fd854f8a56efc96ddb4aef58aa4ab0ada0fdf1 Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Thu, 25 Sep 2025 12:48:33 +0200 Subject: [PATCH 1/2] Add `lightning-persister` `tokio` feature to `Cargo.toml` .. to indicate its existence --- lightning-persister/Cargo.toml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lightning-persister/Cargo.toml b/lightning-persister/Cargo.toml index 5bae5bc418f..593e19a95f7 100644 --- a/lightning-persister/Cargo.toml +++ b/lightning-persister/Cargo.toml @@ -13,6 +13,9 @@ edition = "2021" all-features = true rustdoc-args = ["--cfg", "docsrs"] +[features] +tokio = ["dep:tokio"] + [dependencies] bitcoin = "0.32.2" lightning = { version = "0.2.0", path = "../lightning" } From 96ad240941d2a1a1ee97d576cd29b5967413465c Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Thu, 25 Sep 2025 12:45:25 +0200 Subject: [PATCH 2/2] Add tests for `lightning-persister` with `tokio` feature to CI We recently introduced a new `tokio` feature to `lightning-persister`, but never added it to CI which has us never run the tests that depend on it. Here we fix this omission. --- ci/ci-tests.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh index d2bd4facaee..f78414052f5 100755 --- a/ci/ci-tests.sh +++ b/ci/ci-tests.sh @@ -90,6 +90,11 @@ cargo check -p lightning-block-sync --verbose --color always --features rpc-clie cargo test -p lightning-block-sync --verbose --color always --features rpc-client,rest-client,tokio cargo check -p lightning-block-sync --verbose --color always --features rpc-client,rest-client,tokio +echo -e "\n\nChecking and testing lightning-persister with features" +cargo test -p lightning-persister --verbose --color always --features tokio +cargo check -p lightning-persister --verbose --color always --features tokio +cargo doc -p lightning-persister --document-private-items --features tokio + echo -e "\n\nTest Custom Message Macros" cargo test -p lightning-custom-message --verbose --color always [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean