-
Notifications
You must be signed in to change notification settings - Fork 423
Update main post 0.2 release
#4260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main post 0.2 release
#4260
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4260 +/- ##
==========================================
- Coverage 89.33% 89.31% -0.03%
==========================================
Files 180 180
Lines 139042 139042
Branches 139042 139042
==========================================
- Hits 124219 124185 -34
- Misses 12196 12229 +33
- Partials 2627 2628 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lightning-types/Cargo.toml
Outdated
| [package] | ||
| name = "lightning-types" | ||
| version = "0.3.0+git" | ||
| version = "0.4.0+git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we won't actually bump the version here in a new release, so maybe we don't touch it until we have a PR breaking semver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, that's probably preferable. Now force-pushed an update that only bumps lightning for now.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
We bump the `+git` version numbers, fixing the SemVer checks.
7203f3a to
29d97a2
Compare
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
We update the
CHANGELOGand version numbers onmain, also to fix the SemVer checks CI.