Skip to content

Conversation

@tnull
Copy link
Contributor

@tnull tnull commented Dec 4, 2025

We update the CHANGELOG and version numbers on main, also to fix the SemVer checks CI.

@tnull tnull requested a review from TheBlueMatt December 4, 2025 10:01
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 4, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (de384ff) to head (29d97a2).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4260      +/-   ##
==========================================
- Coverage   89.33%   89.31%   -0.03%     
==========================================
  Files         180      180              
  Lines      139042   139042              
  Branches   139042   139042              
==========================================
- Hits       124219   124185      -34     
- Misses      12196    12229      +33     
- Partials     2627     2628       +1     
Flag Coverage Δ
fuzzing 34.99% <ø> (-0.98%) ⬇️
tests 88.68% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[package]
name = "lightning-types"
version = "0.3.0+git"
version = "0.4.0+git"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we won't actually bump the version here in a new release, so maybe we don't touch it until we have a PR breaking semver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, that's probably preferable. Now force-pushed an update that only bumps lightning for now.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

We bump the `+git` version numbers, fixing the SemVer checks.
@tnull tnull force-pushed the 2025-12-update-main-post-0.2-release branch from 7203f3a to 29d97a2 Compare December 5, 2025 08:50
@tnull tnull requested a review from TheBlueMatt December 5, 2025 08:53
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TheBlueMatt TheBlueMatt merged commit 3aad911 into lightningdevkit:main Dec 5, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants