Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AbstractVssApi, get/put/list api handlers #10

Closed
wants to merge 1 commit into from
Closed

Add AbstractVssApi, get/put/list api handlers #10

wants to merge 1 commit into from

Conversation

G8XSU
Copy link
Collaborator

@G8XSU G8XSU commented May 12, 2023 •
edited
Loading

Add AbstractVssApi, get/put/list api handlers

@G8XSU G8XSU requested a review from jkczyz May 12, 2023 17:24
This was referenced May 12, 2023
Open
Merged
jkczyz
jkczyz reviewed May 17, 2023
View reviewed changes
Copy link

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good. Is there any test code that you could add?

@G8XSU G8XSU mentioned this pull request May 25, 2023
Merged
@G8XSU
Copy link
Collaborator Author

G8XSU commented May 25, 2023

Added in #12

@G8XSU G8XSU requested a review from jkczyz May 25, 2023 07:26
@jkczyz
Copy link

jkczyz commented Jun 1, 2023

Added in #12

No need to make separate PR for tests, IMO.

@G8XSU
Copy link
Collaborator Author

G8XSU commented Jun 15, 2023

Closing as it was reviewed as part of #12

@G8XSU G8XSU closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkczyz jkczyz Awaiting requested review from jkczyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @jkczyz