Skip to content

Conversation

@tankyleo
Copy link
Contributor

No description provided.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 30, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested review from tnull and removed request for joostjager October 30, 2025 23:19
@tankyleo
Copy link
Contributor Author

Let me know if this is what you have in mind here, I am open to all kinds of renames, and repo restructures.

rust/Cargo.toml Outdated
resolver = "2"
members = ["server", "api", "impls", "auth-impls"]
default-members = ["server"]
members = ["versionedstorageserver", "api", "impls", "auth-impls"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe keep the server directory name, and just rename the crate?

@@ -1,5 +1,5 @@
[package]
name = "server"
name = "versionedstorageserver"
Copy link
Contributor

@tnull tnull Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad enough, but

Suggested change
name = "versionedstorageserver"
name = "versioned-storage-server"

would be preferable.

Grr, this is really ugly. I really start wondering if we should just keep the server naming and rename vss-client to vss-client-ng and be done with it? (could still merge the repos though)

@tankyleo tankyleo requested a review from tnull November 5, 2025 01:10
@tankyleo tankyleo changed the title Rename server to versionedstorageserver Rename server crate to vss-server Nov 5, 2025
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Discussed offline that we're gonna stick with the vss-server/vss-client-ng naming (probably).

@tnull tnull merged commit 8f7a629 into lightningdevkit:main Nov 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants