-
Notifications
You must be signed in to change notification settings - Fork 18
Rename server crate to vss-server
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
d82b41e to
c2d9c07
Compare
c2d9c07 to
68dea9d
Compare
|
Let me know if this is what you have in mind here, I am open to all kinds of renames, and repo restructures. |
rust/Cargo.toml
Outdated
| resolver = "2" | ||
| members = ["server", "api", "impls", "auth-impls"] | ||
| default-members = ["server"] | ||
| members = ["versionedstorageserver", "api", "impls", "auth-impls"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe keep the server directory name, and just rename the crate?
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "server" | |||
| name = "versionedstorageserver" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad enough, but
| name = "versionedstorageserver" | |
| name = "versioned-storage-server" |
would be preferable.
Grr, this is really ugly. I really start wondering if we should just keep the server naming and rename vss-client to vss-client-ng and be done with it? (could still merge the repos though)
68dea9d to
4529dbe
Compare
server to versionedstorageserverserver crate to vss-server
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussed offline that we're gonna stick with the vss-server/vss-client-ng naming (probably).
No description provided.