Skip to content

Conversation

@nicolasburtey
Copy link
Contributor

No description provided.

@guggero
Copy link
Collaborator

guggero commented Jun 25, 2021

Thanks for creating the PR. Though this change doesn't really have any effect since the version of github.com/lightningnetwork/lnd is overwritten by the replace directive below.
Very weird that you got a segfault. Is it possible you tried with a binary built for the wrong architecture? It seems to have worked once you built from source?

@nicolasburtey
Copy link
Contributor Author

Is it possible you tried with a binary built for the wrong architecture? It seems to have worked once you built from source?

I had faced same issue with the darwin binary on mac, and linux binary on linux.
building it on my mac with this diff fix the issue somehow.

not a go dev so not sure why that would be. Markus help me to do the diff above.

@guggero
Copy link
Collaborator

guggero commented Jun 25, 2021

Okay, weird... I guess I'll merge this then.
Just to confirm: Building from source without the diff still resulted in the segfault issue?

@guggero guggero merged commit 2d1c83c into lightninglabs:master Jun 25, 2021
@nicolasburtey
Copy link
Contributor Author

nicolasburtey commented Jun 25, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants