This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Add padding for notification dropdown on Android #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you post a before/after screenshot? Don't think this affects the Pixel 2 XL. |
halseth
reviewed
May 6, 2019
| }, | ||
| dropdown: { | ||
| backgroundColor: color.blackDark, | ||
| paddingTop: Platform.OS === 'android' ? 25 : 0, |
Contributor
There was a problem hiding this comment.
I think this should be the height of the status bar instead: https://stackoverflow.com/questions/35436643/how-to-find-height-of-status-bar-in-android-through-react-native
Contributor
Author
There was a problem hiding this comment.
@halseth good call. Didn't know about StatusBar.currentHeight. Fixed and tested on Pixel 2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.