Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Dev/react native v8 #1303

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Dev/react native v8 #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4981cf9
Add react-native-v8 npm dependency
tanx Aug 27, 2019
84d9399
Patch build.gradle files to use libv8.so instead of libjsc.so
tanx Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mobile/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ android {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
packagingOptions {
// Make sure libjsc.so does not packed in APK
exclude "**/libjsc.so"
}
}

dependencies {
Expand All @@ -150,6 +154,8 @@ dependencies {
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
implementation "com.facebook.react:react-native:+" // From node_modules
// Add v8-android - prebuilt libv8.so into APK
implementation 'org.chromium:v8-android:+'
addUnimodulesDependencies()

implementation project(":Lndmobile")
Expand Down
8 changes: 6 additions & 2 deletions mobile/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,12 @@ allprojects {
google()
jcenter()
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url "$rootDir/../node_modules/react-native/android"
// Replace AAR from original RN with AAR from react-native-v8
url("$rootDir/../node_modules/react-native-v8/dist")
}
maven {
// prebuilt libv8.so
url("$rootDir/../node_modules/v8-android/dist")
}
}
}
Expand Down
13 changes: 13 additions & 0 deletions mobile/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"react-native-share": "^1.2.1",
"react-native-svg": "^9.6.2",
"react-native-unimodules": "^0.5.4",
"react-native-v8": "^0.59.10-patch.1",
"react-navigation": "^3.11.1"
},
"devDependencies": {
Expand Down