Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

This PR prepares litd for the v0.16.0-alpha release.

@gemini-code-assist
Copy link

Summary of Changes

Hello @ViktorT-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on preparing litd for its v0.16.0-alpha release. It involves updating the application's internal version identifier and ensuring that all relevant documentation, including compatibility tables and release notes, is current and accurate. Additionally, it incorporates the latest compatible versions of integrated daemons to maintain system consistency.

Highlights

  • Version Update: The internal appPreRelease constant for litd has been updated from alpha.rc1 to alpha, signifying the progression towards the v0.16.0-alpha release.
  • Dependency Bumps: Several bundled daemon dependencies, including LND, Loop, and Taproot Assets, have been updated to their latest compatible release candidate versions to align with the upcoming litd release.
  • Documentation Alignment: The README.md compatibility tables and the v0.16.0 release notes have been updated to accurately reflect the new litd version and its corresponding daemon versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares litd for the v0.16.0-alpha release by updating version numbers and release notes. The changes in version.go and README.md are correct and align with the new release version. In the release notes, I've pointed out that some specific RPC package versions for Loop and Taproot Assets have been omitted in the new format. While this might be an intentional simplification, it would be good to confirm this to ensure no important information is lost for developers.

@ViktorT-11 ViktorT-11 requested a review from ffranr November 26, 2025 11:52
@ViktorT-11 ViktorT-11 assigned jamaljsr and unassigned jamaljsr Nov 26, 2025
@ViktorT-11 ViktorT-11 requested a review from jamaljsr November 26, 2025 11:52
@ViktorT-11 ViktorT-11 self-assigned this Nov 26, 2025
@ViktorT-11 ViktorT-11 added the no-changelog This PR is does not require a release notes entry label Nov 26, 2025
Comment on lines 173 to -183
## Daemon Versions packaged with LiT

| LiT | LND | Loop | Faraday | Pool | Taproot Assets |
|-----------------------|------------------|--------------|---------------|--------------|------------------|
| **v0.16.0-alpha.rc1** | v0.20.0-beta.rc2 | v0.31.5-beta | v0.2.16-alpha | v0.6.6-beta | v0.7.0-alpha.rc2 |
| **v0.15.3-alpha** | v0.19.3-beta | v0.31.5-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha |
| **v0.15.2-alpha** | v0.19.3-beta | v0.31.2-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha |
| **v0.15.1-alpha** | v0.19.2-beta | v0.31.2-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.1-alpha |
| **v0.15.0-alpha** | v0.19.1-beta | v0.31.2-beta | v0.2.16-alpha | v0.6.6-beta | v0.6.0-alpha |
| **v0.14.1-alpha** | v0.18.5-beta | v0.29.0-beta | v0.2.14-alpha | v0.6.5-beta | v0.5.1-alpha |
| **v0.14.0-alpha** | v0.18.4-beta | v0.29.0-beta | v0.2.13-alpha | v0.6.5-beta | v0.5.0-alpha |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have this table in the README. This information is available in the GitHub release page for each lit release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. Should we leave this for now though, and discuss this with the overall team and potentially drop these in a separate PR? Just so that the release doesn't get stalled on that. Same applies for:
#1178 (comment)

Comment on lines -67 to -83
## Compatibility

Full Lightning Terminal functionality can be dependent on running a compatible
version of `lnd`. View the table below to ensure that you run a compatible
version of `lnd` with the relevant `litd` release.

This version compatibility dependency table is only relevant when running litd
in remote mode (meaning that `lnd-mode=remote` is set). It shows the
**_minimum_** `lnd` version that can be used with different versions of `litd`
(LiT). The bundled version will always come with the correct,
[compatible versioning](#daemon-versions-packaged-with-lit).

| LiT | LND |
|-----------------------|--------------|
| **v0.16.0-alpha.rc1** | v0.19.0-beta |
| **v0.15.3-alpha** | v0.19.0-beta |
| **v0.15.2-alpha** | v0.19.0-beta |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO min LND version support should just be in the release notes on the GitHub release page. I think of this as release specific data and not really top level project README data. I think we should retire this table to ./docs and just add a note to the GitHub release page (and template).

@ffranr
Copy link
Contributor

ffranr commented Nov 26, 2025

Theme of my review is: why are we doing things like that 😄

Maybe we can avoid updating the README for each new release?

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👌

Tested the litd and Terminal UIs against this. Also ran the Terminal e2e tests with no issues.

@ViktorT-11
Copy link
Contributor Author

Thanks a lot for the review @jamaljsr 🎉! Sorry, I managed to miss-click on re-request review, so please just ACK again if possible :).

Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can take another look at rm-ing README lines another time 👍

@ffranr ffranr merged commit 1ee7abd into lightninglabs:master Nov 26, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR is does not require a release notes entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants