litrpc: add REST annotations for Litd RPC services #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if you want to address it in this PR or separately, but many of the RPC methods are missing comments in the proto files. It would improve the API docs site if each one had a comment which included the CLI command (example) so that the Code Samples |
|
Great point @jamaljsr! Added them to this PR :) |
guggero
reviewed
Mar 20, 2023
ellemouton
commented
Mar 20, 2023
ellemouton
force-pushed
the
litREST
branch
2 times, most recently
from
173376f
to
6ed90db
Compare
ellemouton
force-pushed
the
litREST
branch
2 times, most recently
from
97990c0
to
e203fee
Compare
ellemouton
force-pushed
the
litREST
branch
2 times, most recently
from
25339c3
to
1d52b37
Compare
|
also updated the very last commit to add |
jamaljsr
reviewed
Mar 20, 2023
jamaljsr
reviewed
Mar 20, 2023
Add missing lit service protos to 'build-protos.js' and run `make protos`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add REST annotations for all LitD RPC services and register them with the REST handler. Update all itests accordingly.
Also filled in lots of missing comments & added
litcliannotations :)