loopout: don't print htlc address

[hieblmi]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the user experience of the loopout command by removing the HTLC address from the standard output after a swap is initiated. This change aims to declutter the console, presenting only the most essential information to the user without omitting critical details.

Highlights

• Output Streamlining: The pull request removes the display of the HTLC address from the console output when a loop out swap is initiated, simplifying the information presented to the user.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the printing of the HTLC address to the console when a loop out swap is initiated. This is a good change as it improves user privacy by not exposing potentially sensitive on-chain information. The removed line was also using a deprecated field, which further justifies its removal. The change is correct and I approve it.

[starius]

LGTM! 🏆

If someone really needs this info, it can be found in loop listswaps output. (Maybe it makes sense to hide it there as well under --verbose option or something.)

Also loop in still prints HTLC address. I propose to remove it as well.

[hieblmi]

For loop ins with --external we want to print the htlc.