autoloop: refactoring to prepare for loopin #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
bhandras
reviewed
Feb 2, 2021
This function is already quite long, and will be extended in the commits to follow, so we move it to the calling function.
carlaKC
force-pushed
the
autoloop-0-refactoring
branch
from
d449304 to
68a5336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some preparatory changes to generalize our autoloop code to add loop in functionality. Mostly renames, so pulled it out to simplify review.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes