gomod: update to Go 1.24.6 and `golangci-lint` v2 #993

hieblmi · 2025-08-19T10:46:10Z

This PR upgrades loop's go version to 1.24.6, upgrades the linter to v2.4.0 and migrates the .golangci.yml file and fixes lint issues.

gemini-code-assist

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on essential maintenance by upgrading the project's Go version to 1.24.6 and updating the golangci-lint tool to its latest v2 release. These updates necessitate a refactoring of the linter configuration file and several minor code adjustments to comply with the new linter rules and improve overall code quality and readability. The changes ensure the project benefits from the latest language features, performance enhancements, and robust static analysis capabilities.

Highlights

Go Version Upgrade: The Go programming language version has been upgraded from 1.23.12 to 1.24.6, ensuring compatibility with the latest language features and performance improvements.
Linter Upgrade and Configuration Refactor: The static analysis tool 'golangci-lint' has been updated to version 2.4.0, along with a comprehensive migration of its configuration file (.golangci.yml) to the new v2 format. This includes restructuring settings and exclusions.
Lint Issue Resolution and Code Style Improvements: Numerous minor code style and error handling adjustments have been made across various Go files to resolve issues flagged by the updated linter. This includes changes to 'if err := ...' patterns, mutex declarations, and adding readability-enhancing blank lines.
Development Environment Updates: The project's Dockerfile for development tools has been updated to reflect the new Go version and linter changes, streamlining the build environment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully upgrades the Go version to 1.24.6 and migrates the golangci-lint configuration to the v2 format. The changes are well-executed, including dependency updates and numerous lint fixes that improve code quality and maintainability.

Key improvements include:

Correcting a bug in loopd/daemon.go where an incorrect error variable was being logged.
Fixing several instances of variable shadowing.
Improving error handling by using errors.Is in routing_plugin.go.
Reordering struct fields for better memory alignment.

Overall, this is a solid maintenance PR that brings the project up to date with its tooling and dependencies. I have one specific comment on the bug fix.

gemini-code-assist · 2025-08-19T10:49:21Z

loopd/daemon.go

 	startErr := d.startWebServers()
 	if startErr != nil {
-		errorf("Error while starting daemon: %v", err)
+		errorf("Error while starting daemon: %v", startErr)


This change corrects a bug where the wrong error variable was being logged. The original code logged err, which is assigned in a separate goroutine and could be nil or stale here, instead of startErr which holds the actual error from d.startWebServers(). This fix ensures the correct error is logged, which is crucial for debugging.

hieblmi · 2025-08-19T11:41:08Z

.golangci.v1.bck.yml

@@ -0,0 +1,149 @@
+run:


Should we keep the v1 file around as a backup?

I don't think we need them, we can always just restore right?

We would be able to recover it from Git if needed.

deleted the file

starius

LGTM 📈
Thanks for updating it! I left several comments.

starius · 2025-08-19T14:38:18Z

loopd/daemon.go

 	swapClientServer

+	// To be used atomically.
+	started int32


Can we use atomic.Bool? (In a separate commit.)

added commit f97c18d

starius · 2025-08-19T14:48:45Z

.github/workflows/main.yml

  # If you change this value, please change it in the following files as well:
  # /Dockerfile
-  GO_VERSION: 1.24.0
+  GO_VERSION: 1.24.6


There is a typo in the commit message: "upgarde"

starius · 2025-08-19T14:50:16Z

tools/Dockerfile

-  && chmod -R 777 /tmp/build/
+RUN mkdir -p /tmp/build/.cache /tmp/build/.modcache \
+ && cd /tmp/tools \
+ && go install -trimpath github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.4.0 \


@v2.4.0 is not needed, because the version is fixed in go.mod.

starius · 2025-08-19T16:13:26Z

executor.go


 // executor is responsible for executing swaps.
 //
 // TODO(roasbeef): rename to SubSwapper.


I think we this TODO is outdated and can be removed.

starius · 2025-08-19T16:18:54Z

liquidity/liquidity.go

 // Run periodically checks whether we should automatically dispatch a loop out.
 // We run this loop even if automated swaps are not currently enabled rather
-// than managing starting and stopping the ticker as our parameters are updated.
+// than managing to start and stop the ticker as our parameters are updated.


We run this loop even if automated swaps are not currently enabled, instead of starting and stopping the ticker whenever our parameters are updated.

better, updated

starius · 2025-08-19T16:20:25Z

staticaddr/deposit/deposit.go

+	// Outpoint of the deposit.
+	wire.OutPoint
+
+	sync.Mutex


I would move the mutex to the beginning. Maybe it also makes sense to make wire.OutPoint non-anonymous.

bhandras

LGTM 🎉 Thank you!

bhandras · 2025-08-19T14:07:31Z

.golangci.v1.bck.yml

@@ -0,0 +1,149 @@
+run:


I don't think we need them, we can always just restore right?

go is updated to v1.24.6 and golangci from v1.64.6 to v2.4.0.

Migrated with `golangci-lint migrate --skip-validation`

fixes tests TestLoopOutFailOffchain, TestLoopOutPaymentParameters

hieblmi force-pushed the asciicheck branch from 6b43db3 to 5ffb14f Compare August 19, 2025 10:47

gemini-code-assist bot reviewed Aug 19, 2025

View reviewed changes

hieblmi force-pushed the asciicheck branch from 5ffb14f to cc14505 Compare August 19, 2025 10:49

gemini-code-assist bot reviewed Aug 19, 2025

View reviewed changes

hieblmi force-pushed the asciicheck branch 2 times, most recently from 1252fc8 to 4f877dd Compare August 19, 2025 11:16

hieblmi self-assigned this Aug 19, 2025

hieblmi commented Aug 19, 2025

View reviewed changes

hieblmi force-pushed the asciicheck branch 2 times, most recently from 4ba877d to 7d9c650 Compare August 19, 2025 12:55

hieblmi requested review from bhandras, sputn1ck and starius August 19, 2025 13:48

hieblmi force-pushed the asciicheck branch 3 times, most recently from 847f2ef to 17e1945 Compare August 19, 2025 15:12

starius approved these changes Aug 19, 2025

View reviewed changes

bhandras approved these changes Aug 19, 2025

View reviewed changes

hieblmi force-pushed the asciicheck branch 2 times, most recently from f97c18d to 35be4c0 Compare August 19, 2025 19:56

hieblmi added 6 commits August 19, 2025 21:56

gomod: upgrade go version and golangci

2ed543b

go is updated to v1.24.6 and golangci from v1.64.6 to v2.4.0.

go.mod: fix asciicheck mod error

37d0be2

linter: migrate .golangci.yml from v1 to v2

fe747a0

Migrated with `golangci-lint migrate --skip-validation`

test: fix nil dereference

cc26813

fixes tests TestLoopOutFailOffchain, TestLoopOutPaymentParameters

loopd: log correct error if daemon start fails

bd6271e

linter: fix lint issues after linter v2 update

e98f733

hieblmi force-pushed the asciicheck branch from 35be4c0 to f9b8139 Compare August 19, 2025 19:57

loopd: atomic var to enforce daemon singelton

38a4496

hieblmi force-pushed the asciicheck branch from f9b8139 to 38a4496 Compare August 19, 2025 20:08

hieblmi merged commit 98fece4 into lightninglabs:master Aug 19, 2025
4 checks passed

hieblmi deleted the asciicheck branch August 19, 2025 20:26

gomod: update to Go 1.24.6 and golangci-lint v2 #993

gomod: update to Go 1.24.6 and golangci-lint v2 #993

Uh oh!

Conversation

hieblmi commented Aug 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

starius left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hieblmi Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gomod: update to Go 1.24.6 and `golangci-lint` v2 #993

gomod: update to Go 1.24.6 and `golangci-lint` v2 #993

hieblmi Aug 19, 2025 •

edited

Loading