staticaddr: filter unavailable deposits in ListUnspentDeposits

[hieblmi]

fixes #992

ListUnspentRaw returns the unspent wallet view of the
backing lnd wallet. It might be that deposits show up
there that are actually not spendable because they
already have been used but not yet spent by the server.
We filter out such deposits in ListUnspentDeposits.

[gemini-code-assist]

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the ListUnspentDeposits RPC call to accurately reflect truly spendable deposits. Previously, the system might list deposits that were technically unspent by the underlying LND wallet but were already consumed or in a non-spendable state by the loop server. This change introduces a filtering mechanism to ensure that only deposits available for new swaps are presented, improving the accuracy and usability of the deposit listing.

Highlights

• Deposit Filtering: Implemented filtering logic within the ListUnspentDeposits RPC handler to exclude deposits that are not truly available for spending.
• Filtering Criteria: Deposits are now filtered based on their confirmation count and their internal state managed by the depositManager.
• Testing: Added comprehensive unit tests to validate the new filtering behavior, covering various scenarios of UTXO confirmations and deposit states.
• Mocking Improvements: Enhanced mock services to support testing the ListUnspent functionality, allowing for more robust testing of wallet interactions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly identifies the need to filter unavailable deposits in ListUnspentDeposits. The implementation adds the necessary filtering logic and corresponding tests. My review focuses on a potential panic and a logic flaw in the new filtering mechanism, for which I've provided a detailed code suggestion. I've also included recommendations to improve test coverage and the clarity of the mock implementation.

[bhandras]

LGTM, very nice! 🎉

[sputn1ck]

LGTM! thanks