Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Batch filter fetching #134
This PR implements batch filter fetching. This is achieved by giving the callers of
I ran this on mainnet to find cache size needed to keep a whole filter batch, and a size of 30 MB could hold at minimum 1483 elements (tested on filters at height > 515110), which should give us some wiggle room.
wpaulino left a comment •
Looks pretty good to me on first pass! Would say I was expecting a more abstracted batching interface where we can batch requests for different non-consecutive height ranges, but the approach implemented here seems to work well assuming that we'll be doing incremental linear scans. One issue I see with the current approach however, is that
Roasbeef left a comment
Still not super satisfied with portions of the new code, but I think we'll defer a greater refactoring in that area until we re-write the batch query interface all together.