build: update to Go 1.21.0 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to use |
|
The RPC and linter containers also need to switch to |
|
Can we move to bookworm (latest stable) instead? |
|
Pushed up a new version that's moved to bookworm. |
|
The RPC compilation docker file needs a change too, as we have hard-coded versions in there (to make sure the compiled/formatted output is deterministic). See lightningnetwork/lnd#7944 (comment) for more info. |
guggero
requested changes
Sep 1, 2023
Running with `buster` in CI gives us this error: ``` ERROR: failed to solve: golang:1.21.0-buster: docker.io/library/golang:1.21.0-buster: not found ``` So looks like the buster container is no longer being officially built. So we'll switch to bookworm for now.
guggero
added a commit
that referenced
this pull request
Sep 7, 2023
In #474 the base image was changed, which resulted in the Docker build not working anymore. We'll follow up this commit with a CI check that makes sure the docker image can be built.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.