Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolt11 encoding capital letters #659

Open
sbtc1 opened this issue Aug 18, 2019 · 2 comments · May be fixed by #677

Comments

@sbtc1
Copy link

commented Aug 18, 2019

The reference documentation does not mention the possibility of using a capitalised invoice (eg LNBC..), still most implementations in the wild seem to accept them.

There are good reasons to support capitalised invoices, like smaller QR codes.

My suggestion is to explicitely mention in the documentation that invoices should be case-independant so that implementations must allow both forms (or even mixed).

@t-bast

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2019

That sounds reasonable. Can you open a pull request to propose that change?

@rustyrussell

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

Note that this is already specified in BIP-0173 which is heavily referenced, however I agree it's good to highlight it.

rustyrussell added a commit to rustyrussell/lightning-rfc that referenced this issue Sep 30, 2019
Explicitly mirror the BIP-173 advice for QR codes, and note the reader
requirements.  In addition, we change the case of one of the examples
to ensure testing.

Fixes: lightningnetwork#659
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell referenced a pull request that will close this issue Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.