New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

07-routing-gossip.md: Describe standard human-readable format for short channel ID. #506

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
7 participants
@ZmnSCPxj
Collaborator

ZmnSCPxj commented Nov 12, 2018

Uncertain if this is best place to describe human-readable format, but, this section is what describes the components of the scid.

@pm47

pm47 approved these changes Nov 12, 2018

You beat me to it!

LGTM

@cdecker

This comment has been minimized.

Collaborator

cdecker commented Nov 12, 2018

ACK 8a4e3fa

and separated from each other by the small letter `x`.
For example, a `short_channel_id` might be written as `539268x845x1`,
indicating a channel on the output 1 of the transaction at index 845
of the block at height 539268.

This comment has been minimized.

@halseth

halseth Nov 13, 2018

Contributor

I'm not a native speaker, but should it be "index 845 in the block?

This comment has been minimized.

@rustyrussell

rustyrussell Nov 26, 2018

Collaborator

Either one works, in this case. I would have said "the first output of the 845th transaction in the block at height 539268", but it's perfectly clear as-is.

This comment has been minimized.

@ZmnSCPxj

ZmnSCPxj Nov 14, 2018

Collaborator

Construction "x of y" can mean "x is a part of y" or "x comes from y" or "x is owned by y", by my understanding of this language. So we can consider "the transaction at index N of the block" as the transaction (which happens to be at index N) that is part of the block.

@rustyrussell rustyrussell added this to the v1.1 milestone Nov 14, 2018

@renepickhardt

as discussed in Adelaide. Though I am said to see the : go away. Those were very good for readability (:

The `short_channel_id` human readable format is designed
so that double-clicking or double-tapping it will select the entire ID
on most systems.

This comment has been minimized.

@renepickhardt

renepickhardt Nov 16, 2018

... on most operating systems ...

and separated from each other by the small letter `x`.
For example, a `short_channel_id` might be written as `539268x845x1`,
indicating a channel on the output 1 of the transaction at index 845
of the block at height 539268.

This comment has been minimized.

@rustyrussell

rustyrussell Nov 26, 2018

Collaborator

Either one works, in this case. I would have said "the first output of the 845th transaction in the block at height 539268", but it's perfectly clear as-is.

@ZmnSCPxj ZmnSCPxj merged commit 67b96de into lightningnetwork:master Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ZmnSCPxj ZmnSCPxj deleted the ZmnSCPxj:new-scid branch Nov 26, 2018

@Jagkree

This comment has been minimized.

Jagkree commented Nov 28, 2018

ดึงสิ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment