New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

04-onion-routing.md: Prepare for extra onion blob encoding. #507

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ZmnSCPxj
Collaborator

ZmnSCPxj commented Nov 13, 2018

No description provided.

@ZmnSCPxj

This comment has been minimized.

Collaborator

ZmnSCPxj commented Nov 13, 2018

I used per_hop_type instead of agree upon type, but I feel type is imprecise as we also use the same term for message ID.

@ZmnSCPxj ZmnSCPxj force-pushed the ZmnSCPxj:realm-to-type branch from e3f135e to 27c6d11 Nov 13, 2018

@ZmnSCPxj

This comment has been minimized.

Collaborator

ZmnSCPxj commented Nov 13, 2018

I have also named per_hop_type 0 to normal_per_hop.

@@ -161,22 +161,22 @@ and has the following structure:
1. type: `hops_data`
2. data:
* [`1`:`realm`]
* [`1`:`per_hop_type`]

This comment has been minimized.

@Roasbeef

Roasbeef Nov 26, 2018

Member

Naming suggestion: packet type?

This comment has been minimized.

@ZmnSCPxj

ZmnSCPxj Nov 27, 2018

Collaborator

That does seem better.

@rustyrussell rustyrussell added this to the v1.1 milestone Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment