New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 4: Clarify final_incorrect_cltv_expiry data #555

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@nayuta-ueno
Copy link
Contributor

nayuta-ueno commented Jan 22, 2019

use update_add_htlc.cltv_expiry like final_incorrect_htlc_amount.

@rustyrussell

This comment has been minimized.

Copy link
Collaborator

rustyrussell commented Feb 4, 2019

This is the final node, so it has to be incoming? More precisely, it is the value in the update_add_htlc, not the value in the onion (the onion is presumably correct!).

@nayuta-ueno

This comment has been minimized.

Copy link
Contributor Author

nayuta-ueno commented Feb 4, 2019

final_incorrect_htlc_amount has incoming_htlc_amt.
Do you think final_incorrect_htlc_amount's incoming_htlc_amt --> amount_msat ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment