New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify OP_DATA to express accepted/offered_htlc_script with same #558

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@ariard
Copy link
Contributor

ariard commented Jan 25, 2019

convention

@@ -691,7 +691,8 @@ The *expected weight* of an HTLC transaction is calculated as follows:
- remotepubkey: 33 bytes
- OP_SWAP: 1 byte
- OP_SIZE: 1 byte
- 32: 2 bytes
- OP_DATA: 1 byte (32 length)

This comment has been minimized.

@Roasbeef

Roasbeef Feb 4, 2019

Member

There isn't a plan OP_DATA opcode. This should specify the precise data push.

This comment has been minimized.

@rustyrussell

rustyrussell Feb 4, 2019

Collaborator

It's used everywhere else, because there's no good name for these opcodes. At least it's spelled out instead of implied as is often done.

This comment has been minimized.

@ariard

ariard Feb 4, 2019

Author Contributor

So do you prefer OP_PUSHBYTES_32 ? Don't have any strong feeling on any of naming, just to get the same everywhere and explicit.

@rustyrussell

This comment has been minimized.

Copy link
Collaborator

rustyrussell commented Feb 4, 2019

I've assigned @Roasbeef to do a comprehensive sweep, but as this just brings it into line with the others, the decision was to apply.

@rustyrussell rustyrussell merged commit 6508af5 into lightningnetwork:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment