Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 4: fix onion test vectors #570

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@sstone
Copy link
Collaborator

commented Feb 10, 2019

Final result was correct but intermediary results had not been updated when the payloads were changed.
Fixes #494

BOLT 4: fix onion vectors
Final result was correct but intermediary results had not been updated when the payloads were changed.
Fixes #494

@sstone sstone changed the title BOLT 4: fix onion vectors BOLT 4: fix onion test vectors Feb 10, 2019

@rustyrussell rustyrussell added this to the v1.0 milestone Feb 12, 2019

@rustyrussell
Copy link
Collaborator

left a comment

Ack. I hacked our implementation to print out the intermediate results, and matched these.

@cdecker

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2019

ACK

Spec meeting voted to apply.

@rustyrussell rustyrussell merged commit da71867 into lightningnetwork:master Feb 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sstone sstone deleted the sstone:bolt4-fix-test-vectors branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.