Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature bit unification and assignment #571
This is modified from the ml proposal: I hadn't appreciated that both channel_announcement and node_announcement have features fields.
Since you have to see a channel_announcement[*] to use a channel, it makes sense for "stuff you need to know to route through here" to go there. Since you need the node_announcement to connect to a node, it makes sense for that to advertize every feature you might want to select on.
The rough assignment is mainly to show the results, to get feedback and allow early experimentation. I won't renumber them if we remove/add any though!