Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify tlv format, initial MPP #572

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rustyrussell
Copy link
Collaborator

commented Feb 12, 2019

No description provided.

@rustyrussell rustyrussell added this to the v1.1 milestone Feb 12, 2019

rustyrussell added some commits Feb 12, 2019

BOLT 1: Specify General Rules for TLV fields.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
BOLT 4: initial TLV values and rules for onion
This doesn't specify *how* they are encoded in the onion, since that's
still being discussed.

Currently it just defines switch_chain and switch_ephkey, which are
simple.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
BOLT11: Add `9` field for feature bits.
I don't use the odd-is-OK rule, because we have many other ways to break
the format if we really want it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
BOLT 4, 11: multi-part payments ("base AMP").
Note the warning on non-amount MPP: unlike real goods with a receipt,
the recipient is not necessarily motivated to wait for the entire
payment (esp. if it's about to time out).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/specify-tlv-format branch from e5b2f45 to 490a5b7 Feb 12, 2019

@niftynei niftynei referenced this pull request Apr 3, 2019

Merged

TLV parsing #2501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.