Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 11: change default expiry to 86400 seconds (1 day) #578

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@prusnak
Copy link

prusnak commented Feb 20, 2019

context: https://twitter.com/francispouliot_/status/1098193142170439680

We open channel if no route found, wait 6 confs (1h), pay. Default Bolt11 expiry in C-Lightning/LND is 3600 secs (1h). Payment failures are guaranteed by default UX configs.

Should be 86400 (1 day).

The average time it takes to open a channel is exactly the time it takes for an invoice to expire. If an invoice expires, I need to send an email to the user, he must come back to the app, create a new Bolt11 w/same node, and we try again. Changing 3600 to 86400 solves it

fix in c-lightning: FrancisPouliot/lightning@3f0d93b

fix in LND: prusnak/lnd@0b6212c

@rustyrussell

This comment has been minimized.

Copy link
Collaborator

rustyrussell commented Mar 4, 2019

This leaves it uncertain for older clients, who would see an empty expiry as meaning 1 hour, not 1 day. However, the failure mode in this case is fairly harmless, and nodes can explicitly use x=86400 during the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.