Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update CSV generator to output fields for tlv's and subtypes #597

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@niftynei
Copy link
Contributor

niftynei commented Apr 2, 2019

v1.1 message formats add new types (tlv's and subtypes). this updates
the csv extraction tool to appropriately output them

tools: update CSV generator to output fields for tlv's and subtypes
v1.1 message formats add new types (tlv's and subtypes). this updates
the csv extraction tool to appropriately output them

@niftynei niftynei referenced this pull request Apr 2, 2019

Merged

Subtype Parsing #2511

niftynei added a commit to niftynei/lightning that referenced this pull request Apr 3, 2019

tlv: adapt to work with new output format
Updated to match what the CSV generator in the RFC repo actually
outputs, see lightningnetwork/lightning-rfc#597

rustyrussell added a commit to ElementsProject/lightning that referenced this pull request Apr 3, 2019

tlv: adapt to work with new output format
Updated to match what the CSV generator in the RFC repo actually
outputs, see lightningnetwork/lightning-rfc#597
@rustyrussell
Copy link
Collaborator

rustyrussell left a comment

It'd be nice to have the output form listed somewhere too (it's currently pretty undocumented).

else:
print("{},{}".format(
match.group('name'),
str(match.group('value') or '$')), file=output)

This comment has been minimized.

Copy link
@rustyrussell

rustyrussell Apr 8, 2019

Collaborator

I think subtypes should just be a single field, ie. no value. Rather than a double field with a magic '$' sign?

niftynei added some commits Apr 9, 2019

extract-format: change subtypes to print without '$'
subtypes used to use a magic '$' to designate that they
were embedded; now we print them without magic.

previous:
input_info,$
input_info,0,xxx

now:
input_info
input_info,0,xxx

previous:
funding_message,2,field,8
funding_message,10,num_inputs,2
funding_message,12,input_info,$num_inputs

now:
funding_message,2,field,8
funding_message,10,num_inputs,2
funding_message,12,input_info,num_inputs*input_info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.