Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT5: Unify two practically redundant paragraphs #609

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jtimon
Copy link

commented May 13, 2019

The two paragraph seem quite redundant and repetitive. Perhaps the resulting one can even be simplified even further.

@cdecker

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

ACK 4f35fd3

@jtimon

This comment has been minimized.

Copy link
Author

commented May 13, 2019

As discussed on IRC, the second paragraph seems just a more specific version of the first one. So I could simply remove the first paragraph and leave the second one as is. Or I could just leave it at what I have now, or follow some other suggestion too.

@jtimon

This comment has been minimized.

Copy link
Author

commented May 14, 2019

Please, chose between commit 1 alone or both squashed. I think we all agree both options are improvements, I don't care either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.