Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
BOLT 07: delay announcement_signatures by max(6, min_depth) confs #625
This PR modifies the sending requirements of
Note that the current wording is conflicting, as BOLT 2 say that BOLT 7 message retransmission is independent of BOLT 2 retransmission, though the current
The proposed fix here is to relax the ordering constraints on
This change makes it easier for implementations to isolate critical forwarding functionality from non-critical processing of gossip traffic via isolated daemons or subsystems.
See prior discussion on #620
referenced this pull request
Jun 25, 2019
renepickhardt left a comment
As far as I understand the process for channel opening this PR is not specific enough. Only the fundee sets a
Let's say A funds a channel with
On a side note: while I understand your request one thing bothers me. If for some reason the
Thanks for the feedback @renepickhardt
I can see how that could be confusing, I've updated the wording to be more specific. I was under the assumption that since the both parties use the same fundee-proposed
A conservative node may still choose to send its
I'm more concerned with the case where a node maliciously withholds
What rule do you have in mind?
This effectively reverts #495 without (IMO) sufficient justification. Practically, #495 was important as it allows a node to avoid storing their peers' announcement_signatures prior to announcement (which should wait on having sent and received funding_locked). If you want them to be separate from channel_reestablish, I don't have a huge disagreement there (though it really doesn't seem right - announcement_signatures really makes little sense as a BOLT 7 message - its not about gossip, its about peers exchanging information which they can use to gossip their own channels), but as-is this breaks real things.