Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple tooling fixes #650

Merged

Conversation

@rustyrussell
Copy link
Collaborator

commented Jul 19, 2019

The first two are in #631 already, but the third one is new: @ZmnSCPxj points out in #643 that describing TLVs using ordered lists causes them to be merged on formatting, so we should use unordered lists (which is also logically consistent).

rustyrussell added some commits Jul 26, 2019

tools/extract-formats.py: allow '*' as well as '1.'/'2.'
The format for TLV types looked pretty, but @ZmnSCPxj points out that
successive ordered lists in markdown get merged into one megalist.

If we allow ordered or unordered lists, we're a bit more futureproof
against formatting changes.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tools/extract-formats.py: allow '.' in length fields.
In practice, using '...*type' is the clearest and simplest way to specify
the common case of "the rest of the TLV is an array of 'type'", rather
than some arbitrary expression with a made-up length field.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/tooling-fixes branch from 80cef74 to d08b26f Jul 30, 2019

@t-bast t-bast moved this from Scheduled to Accepted in Specification Meeting Agenda Aug 5, 2019

@cfromknecht
Copy link
Collaborator

left a comment

LGTM

@t-bast

t-bast approved these changes Aug 5, 2019

@rustyrussell

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 6, 2019

@rustyrussell rustyrussell merged commit d498d2a into lightningnetwork:master Aug 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.